crypto: put legacy _handle accessors on prototypes#24269
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
crypto: put legacy _handle accessors on prototypes#24269targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
Creating deprecated accessors each time an object is created is very time consuming. Refs: nodejs#22747 Fixes: nodejs#24266
nodejs-github-bot
added
the
lib / src
targos
added
crypto
Member
|
Why wasn't the |
Contributor
|
Wasn't removed outright because it breaks native modules using it. Deprecation was the first step, outright removal will happen in next major (I think, I'm a bit fuzzy on how fast we can do these things now). |
tniessen
approved these changes
Nov 9, 2018
Member
|
I originally proposed to remove them, but we agreed to add a deprecation cycle first. |
bnoordhuis
approved these changes
Nov 9, 2018
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM but if BC is a concern, then keep in mind that this change affects code that checks obj.hasOwnProperty('_handle').
Member
jasnell
approved these changes
Nov 10, 2018
lpinca
approved these changes
Nov 10, 2018
Member
Author
Trott
added
the
author ready
Member
Author
|
Landed in e83d7e8. |
targos
added a commit
that referenced
this pull request
Nov 11, 2018
Creating deprecated accessors each time an object is created is very time consuming. Refs: #22747 Fixes: #24266 PR-URL: #24269 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
Creating deprecated accessors each time an object is created is very time consuming. Refs: #22747 Fixes: #24266 PR-URL: #24269 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
Creating deprecated accessors each time an object is created is very time consuming. Refs: nodejs#22747 Fixes: nodejs#24266 PR-URL: nodejs#24269 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Nov 15, 2018
Member
|
@targos is this something we'd potentially want to backport to |
Member
Author
|
The change that warranted this was semver-major and isn't in v10.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating deprecated accessors each time an object is created is very
time consuming.
Refs: #22747
Fixes: #24266
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes